chrome/browser/browsing_data/cookies_tree_model_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/cookies_tree_model_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data/cookies_tree_model_unittest.cc

diff --git a/chrome/browser/browsing_data/cookies_tree_model_unittest.cc b/chrome/browser/browsing_data/cookies_tree_model_unittest.cc

index 58b1dd505e352e8424f8a78ff97bc296a139c931..96994145521b37fb64e008077bd320bbaa766b5e 100644

--- a/chrome/browser/browsing_data/cookies_tree_model_unittest.cc

+++ b/chrome/browser/browsing_data/cookies_tree_model_unittest.cc

@@ -416,7 +416,7 @@ TEST_F(CookiesTreeModelTest, RemoveAll) {

SCOPED_TRACE("After removing");

EXPECT_EQ(1, cookies_model->GetRoot()->GetTotalNodeCount());

EXPECT_EQ(0, cookies_model->GetRoot()->child_count());

- EXPECT_EQ(std::string(""), GetDisplayedCookies(cookies_model.get()));

+ EXPECT_EQ(std::string(), GetDisplayedCookies(cookies_model.get()));

EXPECT_TRUE(mock_browsing_data_cookie_helper_->AllDeleted());

EXPECT_TRUE(mock_browsing_data_database_helper_->AllDeleted());

EXPECT_TRUE(mock_browsing_data_local_storage_helper_->AllDeleted());