chrome/common/json_schema/json_schema_validator.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/json_schema/json_schema_validator.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/json_schema/json_schema_validator.cc

diff --git a/chrome/common/json_schema/json_schema_validator.cc b/chrome/common/json_schema/json_schema_validator.cc

index a303442e56dca07455ce0f695c37f6088da6b8e3..6e5e070b40ddfd6033461171d4f962b1b2ed401e 100644

--- a/chrome/common/json_schema/json_schema_validator.cc

+++ b/chrome/common/json_schema/json_schema_validator.cc

@@ -99,7 +99,7 @@ std::string JSONSchemaValidator::GetJSONSchemaType(const Value* value) {

return schema::kArray;

default:

NOTREACHED() << "Unexpected value type: " << value->GetType();

- return "";

+ return std::string();

}

@@ -147,7 +147,7 @@ JSONSchemaValidator::~JSONSchemaValidator() {}

bool JSONSchemaValidator::Validate(const Value* instance) {

errors_.clear();

- Validate(instance, schema_root_, "");

+ Validate(instance, schema_root_, std::string());

return errors_.empty();

}