chrome/common/extensions/update_manifest_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/update_manifest_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/update_manifest_unittest.cc

diff --git a/chrome/common/extensions/update_manifest_unittest.cc b/chrome/common/extensions/update_manifest_unittest.cc

index 9af11dfa59cbc1ffb0c69abe27598e06131227a9..2a16b9c8a340df2dab039254999cc0264fee8976 100644

--- a/chrome/common/extensions/update_manifest_unittest.cc

+++ b/chrome/common/extensions/update_manifest_unittest.cc

@@ -120,7 +120,7 @@ TEST(ExtensionUpdateManifestTest, TestUpdateManifest) {

UpdateManifest parser;

// Test parsing of a number of invalid xml cases

- EXPECT_FALSE(parser.Parse(""));

+ EXPECT_FALSE(parser.Parse(std::string()));

EXPECT_FALSE(parser.errors().empty());

EXPECT_TRUE(parser.Parse(kMissingAppId));