chrome/browser/file_select_helper.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/file_select_helper.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/file_select_helper.cc

diff --git a/chrome/browser/file_select_helper.cc b/chrome/browser/file_select_helper.cc

index 15e4a053bd4ff0db7f5feb6396f4e4eb169dd219..3d07ff28bf0566a91e41ec5a4ac913a196b0cf1c 100644

--- a/chrome/browser/file_select_helper.cc

+++ b/chrome/browser/file_select_helper.cc

@@ -423,9 +423,10 @@ void FileSelectHelper::RunFileChooserOnUIThread(

params.title,

default_file_name,

select_file_types_.get(),

- select_file_types_.get() && !select_file_types_->extensions.empty() ?

- 1 : 0, // 1-based index of default extension to show.

- FILE_PATH_LITERAL(""),

+ select_file_types_.get() && !select_file_types_->extensions.empty()

+ ? 1

+ : 0, // 1-based index of default extension to show.

+ FILE_PATH_LITERAL(std::string()),

owning_window,

#if defined(OS_ANDROID)

&accept_types);