chrome/browser/feedback/feedback_util.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/feedback_util.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/feedback/feedback_util.cc

diff --git a/chrome/browser/feedback/feedback_util.cc b/chrome/browser/feedback/feedback_util.cc

index 7133c607ab22b3e74ee3c8b2869350d5e1c2a744..dba9b2ad3efaff4816ebaab66e3517a2c78cfedc 100644

--- a/chrome/browser/feedback/feedback_util.cc

+++ b/chrome/browser/feedback/feedback_util.cc

@@ -283,7 +283,7 @@ void FeedbackUtil::SendReport(scoped_refptr<FeedbackData> data) {

// CHROMEOS_RELEASE_VERSION from /etc/lsb-release

#if !defined(OS_CHROMEOS)

// Add OS version (eg, for WinXP SP2: "5.1.2600 Service Pack 2").

- std::string os_version = "";

+ std::string os_version = std::string();

SetOSVersion(&os_version);

AddFeedbackData(&feedback_data, std::string(kOsVersionTag), os_version);

#endif