ppapi/shared_impl/ppb_audio_shared.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/ppb_audio_shared.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/shared_impl/ppb_audio_shared.cc

diff --git a/ppapi/shared_impl/ppb_audio_shared.cc b/ppapi/shared_impl/ppb_audio_shared.cc

index f2755598f86a4d33273938473bec0c88382288bb..f6d0cac029942b44d91fc56e0715304c481a1693 100644

--- a/ppapi/shared_impl/ppb_audio_shared.cc

+++ b/ppapi/shared_impl/ppb_audio_shared.cc

@@ -80,8 +80,11 @@ void PPB_Audio_Shared::SetStreamInfo(

if (!shared_memory_->Map(

media::TotalSharedMemorySizeInBytes(shared_memory_size_))) {

- PpapiGlobals::Get()->LogWithSource(instance, PP_LOGLEVEL_WARNING, "",

- "Failed to map shared memory for PPB_Audio_Shared.");

+ PpapiGlobals::Get()->LogWithSource(

+ instance,

+ PP_LOGLEVEL_WARNING,

+ std::string(),

+ "Failed to map shared memory for PPB_Audio_Shared.");

} else {

audio_bus_ = media::AudioBus::WrapMemory(

kChannels, sample_frame_count, shared_memory_->memory());