ppapi/tests/test_file_ref.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/tests/test_file_ref.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/tests/test_file_ref.cc

diff --git a/ppapi/tests/test_file_ref.cc b/ppapi/tests/test_file_ref.cc

index 2dfea855d1d8b0281b8e884bd9bc231b66862d8e..f3217f938c37736cbf70f6ad093ab01750e702c1 100644

--- a/ppapi/tests/test_file_ref.cc

+++ b/ppapi/tests/test_file_ref.cc

@@ -85,7 +85,7 @@ void TestFileRef::RunTests(const std::string& filter) {

std::string TestFileRef::TestCreate() {

std::vector<std::string> invalid_paths;

invalid_paths.push_back("invalid_path"); // no '/' at the first character

- invalid_paths.push_back(""); // empty path

+ invalid_paths.push_back(std::string()); // empty path

// The following are directory traversal checks

invalid_paths.push_back("..");

invalid_paths.push_back("/../invalid_path");