chrome/browser/search/search.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/search.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search/search.cc

diff --git a/chrome/browser/search/search.cc b/chrome/browser/search/search.cc

index 83186b473ca8bfe6fdb3c3d9d07486a69eea7c89..726bc89025b1f84a9cc6d019ccf18b4eccabdcde 100644

--- a/chrome/browser/search/search.cc

+++ b/chrome/browser/search/search.cc

@@ -527,7 +527,8 @@ uint64 GetUInt64ValueForFlagWithDefault(const std::string& flag,

uint64 default_value,

const FieldTrialFlags& flags) {

uint64 value;

- std::string str_value = GetStringValueForFlagWithDefault(flag, "", flags);

+ std::string str_value =

+ GetStringValueForFlagWithDefault(flag, std::string(), flags);

if (base::StringToUint64(str_value, &value))

return value;

return default_value;