chrome/browser/search/local_omnibox_popup_source.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/local_omnibox_popup_source.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search/local_omnibox_popup_source.cc

diff --git a/chrome/browser/search/local_omnibox_popup_source.cc b/chrome/browser/search/local_omnibox_popup_source.cc

index 1ae3c8a6f8eb829b7d5650a8d021586d2ad16e40..fa2d940f83ee0fd65191c50b47caa0f03be2bf5a 100644

--- a/chrome/browser/search/local_omnibox_popup_source.cc

+++ b/chrome/browser/search/local_omnibox_popup_source.cc

@@ -76,7 +76,7 @@ std::string LocalOmniboxPopupSource::GetMimeType(

if (path == kPageIconFilename || path == kPageIcon2xFilename ||

path == kSearchIconFilename || path == kSearchIcon2xFilename)

return "image/png";

- return "";

+ return std::string();

}

bool LocalOmniboxPopupSource::ShouldServiceRequest(