chrome/browser/devtools/devtools_sanity_browsertest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_sanity_browsertest.cc

diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc

index 6a8b30ceaf5d6d750fdbd003734095e4eb78da90..4f832f7b771e6018a1572d394aaa9c8d7c11b03a 100644

--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc

+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc

@@ -441,7 +441,7 @@ IN_PROC_BROWSER_TEST_F(

IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest,

TestDevToolsExtensionAPI) {

LoadExtension("devtools_extension");

- RunTest("waitForTestResultsInConsole", "");

+ RunTest("waitForTestResultsInConsole", std::string());

}

// Tests that chrome.devtools extension can communicate with background page

@@ -449,7 +449,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest,

IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest,

TestDevToolsExtensionMessaging) {

LoadExtension("devtools_messaging");

- RunTest("waitForTestResultsInConsole", "");

+ RunTest("waitForTestResultsInConsole", std::string());

}

// Tests that chrome.experimental.devtools extension is correctly exposed

@@ -457,7 +457,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest,

IN_PROC_BROWSER_TEST_F(DevToolsExperimentalExtensionTest,

TestDevToolsExperimentalExtensionAPI) {

LoadExtension("devtools_experimental");

- RunTest("waitForTestResultsInConsole", "");

+ RunTest("waitForTestResultsInConsole", std::string());

}

// Tests that a content script is in the scripts list.

@@ -478,7 +478,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest,

IN_PROC_BROWSER_TEST_F(DevToolsSanityTest,

MAYBE_TestRendererProcessNativeMemorySize) {

- RunTest("testRendererProcessNativeMemorySize", "");

+ RunTest("testRendererProcessNativeMemorySize", std::string());

}

// Tests that scripts are not duplicated after Scripts Panel switch.