chrome/browser/devtools/devtools_file_helper.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_file_helper.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_file_helper.cc

diff --git a/chrome/browser/devtools/devtools_file_helper.cc b/chrome/browser/devtools/devtools_file_helper.cc

index d485a526158f303deda69807d86e6b9c3cabcc3c..4aef09107ea10a82db1fa655801e9f15660f548c 100644

--- a/chrome/browser/devtools/devtools_file_helper.cc

+++ b/chrome/browser/devtools/devtools_file_helper.cc

@@ -77,7 +77,7 @@ class SelectFileDialog : public ui::SelectFileDialog::Listener,

default_path,

NULL,

- FILE_PATH_LITERAL(""),

+ FILE_PATH_LITERAL(std::string()),

NULL,

NULL);

}

@@ -346,7 +346,7 @@ void DevToolsFileHelper::AddValidatedFileSystem(

file_system_id,

registered_name,

file_system_path);

- callback.Run("", filesystem);

+ callback.Run(std::string(), filesystem);

}

void DevToolsFileHelper::RequestFileSystems(