base/metrics/stats_table.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/stats_table.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/stats_table.cc

diff --git a/base/metrics/stats_table.cc b/base/metrics/stats_table.cc

index dede1e4f0552d760f5206d9687864c2ba0884889..9585863089e05f04579514481533b9ead4eb070f 100644

--- a/base/metrics/stats_table.cc

+++ b/base/metrics/stats_table.cc

@@ -431,8 +431,8 @@ int* StatsTable::FindLocation(const char* name) {

// Get the slot for this thread. Try to register

// it if none exists.

int slot = table->GetSlot();

- if (!slot && !(slot = table->RegisterThread("")))

- return NULL;

+ if (!slot && !(slot = table->RegisterThread(std::string())))

+ return NULL;

// Find the counter id for the counter.

std::string str_name(name);