base/json/json_value_serializer_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_value_serializer_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_value_serializer_unittest.cc

diff --git a/base/json/json_value_serializer_unittest.cc b/base/json/json_value_serializer_unittest.cc

index e510500c71f21c6bc91b89ebf93329a53b898ba8..be93d884a4bcf7ce24c4f3bb74a789a60c9361f1 100644

--- a/base/json/json_value_serializer_unittest.cc

+++ b/base/json/json_value_serializer_unittest.cc

@@ -196,7 +196,7 @@ TEST(JSONValueSerializerTest, Roundtrip) {

// initialized with a const string.

ASSERT_FALSE(serializer.Serialize(*root_dict));

- std::string test_serialization = "";

+ std::string test_serialization = std::string();

darin (slow to review) 2013/04/09 05:27:57 nit: gratuitous assignment.

JSONStringValueSerializer mutable_serializer(&test_serialization);

ASSERT_TRUE(mutable_serializer.Serialize(*root_dict));

ASSERT_EQ(original_serialization, test_serialization);