[turbofan] Remove usage of Unique<T> from graph.

[turbofan] Remove usage of Unique<T> from graph.

The usage of Unique<T> throughout the TurboFan IR does not have any
advantage. There is no single point in time when they are initialized
and most use-sites looked through to the underlying Handle<T> anyways.
Also there already was a mixture of Handle<T> versus Unique<T> in the
graph and this unifies the situation to use Handle<T> everywhere.

R=bmeurer@chromium.org,titzer@chromium.org

Committed: https://crrev.com/6e65e6db6c510c320a8433a6793ca1be97d1e52f
Cr-Commit-Position: refs/heads/master@{#30458}

[Michael Starzinger, 2015-08-28 12:08:26]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org, titzer@chromium.org

[Michael Starzinger, 2015-08-28 12:08:44]

mstarzinger@chromium.org changed required reviewers:
+ bmeurer@chromium.org, titzer@chromium.org

[Michael Starzinger, 2015-08-28 12:08:45]

https://codereview.chromium.org/1314473007/diff/1/src/compiler/common-operator.h
File src/compiler/common-operator.h (right):

https://codereview.chromium.org/1314473007/diff/1/src/compiler/common-operato...
src/compiler/common-operator.h:10: #include "src/unique.h"
Removal of includes will be done in another CL, because no longer including
unique.h will open a can or worms throughout the code-base.

https://codereview.chromium.org/1314473007/diff/1/test/unittests/compiler/nod...
File test/unittests/compiler/node-test-utils.h (right):

https://codereview.chromium.org/1314473007/diff/1/test/unittests/compiler/nod...
test/unittests/compiler/node-test-utils.h:76: Matcher<Node*>
IsHeapConstant(Handle<HeapObject> value);
I wasn't able to make the implicit boxing of Handle<T> into a Matcher<T> work.
If it's fine with you, I would like to do that in a follow-up CL. Any help
appreciated.

[titzer, 2015-08-28 12:20:08]

lgtm ich mag

[Benedikt Meurer, 2015-08-28 12:24:33]

LGTM!

[Michael Starzinger, 2015-08-28 13:53:05]

Patchset #3 (id:40001) has been deleted

[Michael Starzinger, 2015-08-28 16:19:38]

OK, after a tirade of fixes for VC++ I got this to compile on all platforms.
This should also fix many UBSan issues because we now perform correct casting in
OpParameter<> throughout the codebase. Now that we are using Handle<T>, which
does not provide an equality comparison operator, all the undefined behavior
cases actually turned into compile errors.

Benedikt, could you PTAL at my changes in the follow-up patch sets? Thanks!

[Michael Starzinger, 2015-08-31 07:58:57]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-08-31 07:58:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1314473007/#ps190001
(title: "Rebased and fixed.")

[commit-bot: I haz the power, 2015-08-31 07:59:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314473007/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314473007/190001

[commit-bot: I haz the power, 2015-08-31 08:24:58]

Committed patchset #10 (id:190001)

[commit-bot: I haz the power, 2015-08-31 08:25:16]

Patchset 10 (id:??) landed as
https://crrev.com/6e65e6db6c510c320a8433a6793ca1be97d1e52f
Cr-Commit-Position: refs/heads/master@{#30458}