Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312413002: Move runtime helper for JSSet and JSMap onto objects. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move runtime helper for JSSet and JSMap onto objects. R=rossberg@chromium.org Committed: https://crrev.com/68dfaf78d84c63d534d382651cafe42bfee2440a Cr-Commit-Position: refs/heads/master@{#30384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -49 lines) Patch
M src/api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/runtime/runtime-collections.cc View 4 chunks +4 lines, -30 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 2 chunks +1 line, -6 lines 0 comments Download

Dependent Patchsets:

Issue 1314053003 Patch 1

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-26 12:16:25 UTC) #1
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-08-26 12:18:26 UTC) #3
rossberg
lgtm
5 years, 3 months ago (2015-08-26 12:20:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312413002/1
5 years, 3 months ago (2015-08-26 12:34:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 12:46:16 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 12:46:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/68dfaf78d84c63d534d382651cafe42bfee2440a
Cr-Commit-Position: refs/heads/master@{#30384}

Powered by Google App Engine
This is Rietveld 408576698