Issue 672553002: DevTools: [FlameChart] focus flamechart when it gets shown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 672553002: DevTools: [FlameChart] focus flamechart when it gets shown (Closed)

Created:
6 years, 2 months ago by lushnikov

Modified:
6 years, 2 months ago

Reviewers:
pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: [FlameChart] focus flamechart when it gets shown There are traceviewer-compliant WASD shortcuts in FlameChart for convenient navigation. However, they are not functional unless the FlameChart is manually selected via mouse click on an *empty* place in flamechart (clicks on flamechart entries send you to sources view). The patch does two things: - makes sidebarPane unselectable so that resizing sidebar won't grab focus - focuses flamechart as it gets displayed R=pfeldman, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184172

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	Source/devtools/front_end/profiler/CPUProfileFlameChart.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/profiler/CPUProfileView.js	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/profiler/ProfilesPanel.js	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672553002/1

6 years, 2 months ago (2014-10-22 09:04:20 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 11:23:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184172

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages