device/hid/hid_service_linux.h - Issue 1312993008: Manage HidService lifetime in DeviceClient implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/hid/hid_service_linux.h

Issue 1312993008: Manage HidService lifetime in DeviceClient implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_usb_service_get_instance

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/hid/hid_service_linux.h

diff --git a/device/hid/hid_service_linux.h b/device/hid/hid_service_linux.h

index 6bcb1a94fc086dc2aa5ed2ca628b1c2461baa56e..45c782d5f95f708b495adc9b2f82c89955d923c7 100644

--- a/device/hid/hid_service_linux.h

+++ b/device/hid/hid_service_linux.h

@@ -22,6 +22,7 @@ class HidConnection;

class HidServiceLinux : public HidService {

public:

HidServiceLinux(scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);

+ ~HidServiceLinux() override;

void Connect(const HidDeviceId& device_id,

const ConnectCallback& callback) override;

@@ -30,8 +31,6 @@ class HidServiceLinux : public HidService {

struct ConnectParams;

class FileThreadHelper;

- ~HidServiceLinux() override;

// These functions implement the process of locating, requesting access to and

// opening a device. Because this operation crosses multiple threads these

// functions are static and the necessary parameters are passed as a single

« no previous file with comments | « device/hid/hid_service.cc ('k') | device/hid/hid_service_linux.cc » ('j') | no next file with comments »