extensions/shell/browser/shell_device_client.cc - Issue 1312993008: Manage HidService lifetime in DeviceClient implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_device_client.cc

Issue 1312993008: Manage HidService lifetime in DeviceClient implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_usb_service_get_instance

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/browser/shell_device_client.cc

diff --git a/extensions/shell/browser/shell_device_client.cc b/extensions/shell/browser/shell_device_client.cc

index ae006661e78193d96cc7a122b1ef8f031b028407..857e2a4f2fcff25d6a4027bc26533ddf4f3fa65e 100644

--- a/extensions/shell/browser/shell_device_client.cc

+++ b/extensions/shell/browser/shell_device_client.cc

@@ -29,8 +29,11 @@ device::UsbService* ShellDeviceClient::GetUsbService() {

device::HidService* ShellDeviceClient::GetHidService() {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- return device::HidService::GetInstance(

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));

+ if (!hid_service_) {

+ hid_service_ = device::HidService::Create(

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));

+ }

+ return hid_service_.get();

}

« no previous file with comments | « extensions/shell/browser/shell_device_client.h ('k') | no next file » | no next file with comments »