Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315723004: DevTools: [CSSP] put -webkit properties to the end of the list. (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: [CSSP] put -webkit properties to the end of the list. The patch puts -webkit-prefixed properties to the end of the list of computed properties list. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201449

Patch Set 1 #

Patch Set 2 : rebase tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M LayoutTests/inspector/elements/elements-panel-styles-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles-2/inherited-mixed-case-properties-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
lushnikov
ptal
5 years, 3 months ago (2015-08-28 01:48:53 UTC) #1
pfeldman
lgtm
5 years, 3 months ago (2015-08-28 16:52:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315723004/1
5 years, 3 months ago (2015-08-28 21:35:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/100350)
5 years, 3 months ago (2015-08-28 22:34:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315723004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315723004/20001
5 years, 3 months ago (2015-08-29 00:52:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/97613)
5 years, 3 months ago (2015-08-29 03:22:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315723004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315723004/20001
5 years, 3 months ago (2015-08-29 03:46:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201449
5 years, 3 months ago (2015-08-29 04:41:14 UTC) #14
PhistucK
Perhaps it should just be sorted alphabetically, with the prefix ignored? ... background background-size -webkit-background-size ...
5 years, 3 months ago (2015-08-29 10:03:01 UTC) #15
lushnikov
5 years, 3 months ago (2015-08-31 21:06:30 UTC) #16
Message was sent while issue was closed. 
On 2015/08/29 10:03:01, PhistucK wrote:
> Perhaps it should just be sorted alphabetically, with the prefix ignored?
> ...
> background
> background-size
> -webkit-background-size
> color
> ...
> padding-right
> -webkit-padding-start
> padding-top
> ...

We drop properties which have unprefixed analogue with the same value (so your
example is technically wrong).
However, we've considered your suggestion, but it looks like most of the time
you don't care about prefixed properties
at all.

Powered by Google App Engine
This is Rietveld 408576698