Chromium Code Reviews Chromium Code Reviews
Issue 1312623003:
Flakyness: fix notifications/ tests. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@webmidi-flakyness| Index: LayoutTests/http/tests/notifications/update-document.html |
| diff --git a/LayoutTests/http/tests/notifications/update-document.html b/LayoutTests/http/tests/notifications/update-document.html |
| index b16a470b2a473af27eda2c58154c158d12d8d12e..0cdccfd601361e310f139538ec40b51eb9603bcb 100644 |
| --- a/LayoutTests/http/tests/notifications/update-document.html |
| +++ b/LayoutTests/http/tests/notifications/update-document.html |
| @@ -5,6 +5,7 @@ |
| <script src="../resources/testharness.js"></script> |
| <script src="../resources/testharnessreport.js"></script> |
| <script src="resources/test-helpers.js"></script> |
| + <script src="../resources/permissions-helper.js"></script> |
| </head> |
| <body> |
| <script> |
| @@ -12,9 +13,11 @@ |
| // property in the constructor's options. When the test is being ran |
| // manually, grant Notification permission first and verify that only a |
| // single notification will be shown at the end of the test. |
| - if (window.testRunner) |
| - testRunner.setPermission('notifications', 'granted', location.origin, location.origin); |
| + PermissionsHelper.setPermission('notifications', 'granted').then(function() { |
| + var script = document.createElement('script'); |
|
mlamouri (slow - plz ping)
2015/08/31 16:31:42
.. and this one.
|
| + script.src = 'resources/update-event-test.js'; |
| + document.body.appendChild(script); |
|
johnme
2015/08/26 12:27:32
I wonder if this is a common enough use case to ad
mlamouri (slow - plz ping)
2015/08/31 16:31:42
Yeah, no need to do that unless it becomes a trend
|
| + }); |
| </script> |
| - <script src="resources/update-event-test.js"></script> |
| </body> |
| </html> |
