LayoutTests/http/tests/notifications/update-document.html - Issue 1312623003: Flakyness: fix notifications/ tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/notifications/update-document.html

Issue 1312623003: Flakyness: fix notifications/ tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@webmidi-flakyness

Patch Set: add missing file Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/notifications/close-document.html ('K') | « LayoutTests/http/tests/notifications/request-permission-promise.html ('k') | LayoutTests/http/tests/resources/permissions-helper.js » ('j') | LayoutTests/http/tests/resources/permissions-helper.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: The "tag" property is able to replace existing notific ations.</title>	4 <title>Notifications: The "tag" property is able to replace existing notific ations.</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="resources/test-helpers.js"></script>	7 <script src="resources/test-helpers.js"></script>

	8 <script src="../resources/permissions-helper.js"></script>

8 </head>	9 </head>

9 <body>	10 <body>

10 <script>	11 <script>

11 // Tests that Document-bound notifications can be replaced using the "tag"	12 // Tests that Document-bound notifications can be replaced using the "tag"

12 // property in the constructor's options. When the test is being ran	13 // property in the constructor's options. When the test is being ran

13 // manually, grant Notification permission first and verify that only a	14 // manually, grant Notification permission first and verify that only a

14 // single notification will be shown at the end of the test.	15 // single notification will be shown at the end of the test.

15 if (window.testRunner)	16 PermissionsHelper.setPermission('notifications', 'granted').then(function( ) {

16 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);	17 var script = document.createElement('script');
	mlamouri (slow - plz ping) 2015/08/31 16:31:42 .. and this one. .. and this one.
	18 script.src = 'resources/update-event-test.js';

	19 document.body.appendChild(script);
	johnme 2015/08/26 12:27:32 I wonder if this is a common enough use case to ad I wonder if this is a common enough use case to add a PermissionsHelper.setPermissionThenRunScript('notifications', 'granted', 'resources/update-event-test.js') style API. I guess we can wait and see... mlamouri (slow - plz ping) 2015/08/31 16:31:42 Yeah, no need to do that unless it becomes a trend Show quoted text On 2015/08/26 at 12:27:32, johnme wrote: > I wonder if this is a common enough use case to add a PermissionsHelper.setPermissionThenRunScript('notifications', 'granted', 'resources/update-event-test.js') style API. I guess we can wait and see... Yeah, no need to do that unless it becomes a trend.
	20 });

17 </script>	21 </script>

18 <script src="resources/update-event-test.js"></script>

19 </body>	22 </body>

20 </html>	23 </html>

OLD	NEW