Chromium Code Reviews Chromium Code Reviews
Issue 1312623003:
Flakyness: fix notifications/ tests. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@webmidi-flakyness| Index: LayoutTests/http/tests/notifications/close-document.html |
| diff --git a/LayoutTests/http/tests/notifications/close-document.html b/LayoutTests/http/tests/notifications/close-document.html |
| index a7121b836fa1d08cc6295f588ebf1ac7147ca957..88c3a9875484cfdc41a75218ed7762b84fe03ddd 100644 |
| --- a/LayoutTests/http/tests/notifications/close-document.html |
| +++ b/LayoutTests/http/tests/notifications/close-document.html |
| @@ -5,15 +5,18 @@ |
| <script src="../resources/testharness.js"></script> |
| <script src="../resources/testharnessreport.js"></script> |
| <script src="resources/test-helpers.js"></script> |
| + <script src="../resources/permissions-helper.js"></script> |
| </head> |
| <body> |
| <script> |
| // Tests that Document-bound notifications will fire the onclose event |
| // when they have their close() method called. When the test is being ran |
| // manually, grant Notification permission first. |
| - if (window.testRunner) |
| - testRunner.setPermission('notifications', 'granted', location.origin, location.origin); |
| + PermissionsHelper.setPermission('notifications', 'granted').then(function() { |
| + var script = document.createElement('script'); |
|
mlamouri (slow - plz ping)
2015/08/31 16:31:42
I also updated this indentation.
|
| + script.src = 'resources/close-event-test.js'; |
| + document.body.appendChild(script); |
| + }); |
| </script> |
| - <script src="resources/close-event-test.js"></script> |
| </body> |
| </html> |
