LayoutTests/http/tests/notifications/close-document.html - Issue 1312623003: Flakyness: fix notifications/ tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/notifications/close-document.html

Issue 1312623003: Flakyness: fix notifications/ tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@webmidi-flakyness

Patch Set: add missing file Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/notifications/click-window-focus-document.html ('K') | « LayoutTests/http/tests/notifications/click-window-focus-document.html ('k') | LayoutTests/http/tests/notifications/request-permission-promise.html » ('j') | LayoutTests/http/tests/notifications/update-document.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: Programatically closing a notification should fire the onclose event.</title>	4 <title>Notifications: Programatically closing a notification should fire the onclose event.</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="resources/test-helpers.js"></script>	7 <script src="resources/test-helpers.js"></script>

	8 <script src="../resources/permissions-helper.js"></script>

8 </head>	9 </head>

9 <body>	10 <body>

10 <script>	11 <script>

11 // Tests that Document-bound notifications will fire the onclose event	12 // Tests that Document-bound notifications will fire the onclose event

12 // when they have their close() method called. When the test is being ran	13 // when they have their close() method called. When the test is being ran

13 // manually, grant Notification permission first.	14 // manually, grant Notification permission first.

14 if (window.testRunner)	15 PermissionsHelper.setPermission('notifications', 'granted').then(function( ) {

15 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);	16 var script = document.createElement('script');
	mlamouri (slow - plz ping) 2015/08/31 16:31:42 I also updated this indentation. I also updated this indentation.
	17 script.src = 'resources/close-event-test.js';

	18 document.body.appendChild(script);

	19 });

16 </script>	20 </script>

17 <script src="resources/close-event-test.js"></script>

18 </body>	21 </body>

19 </html>	22 </html>

OLD	NEW