Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312543003: Split out Attribute from CSSPrimitiveValue (Closed)

Created:
5 years, 3 months ago by sashab
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, esprehn, shans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@clean_up_get_string_value
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Split out Attribute from CSSPrimitiveValue Remove Attributes from CSSPrimitiveValue and updated callsites to instead create CSSFunctionValues. This only affects the 'content' property (no other properties currently support CSS attributes). BUG=523893 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201534

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -32 lines) Patch
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 2 5 chunks +0 lines, -14 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 2 chunks +15 lines, -10 lines 0 comments Download

Dependent Patchsets:

Issue 1306823004 Patch 40001

Messages

Total messages: 7 (3 generated)
sashab
5 years, 3 months ago (2015-08-26 05:07:06 UTC) #2
Timothy Loh
On 2015/08/26 05:07:06, sashab wrote: lgtm, but please mention in the description what these are ...
5 years, 3 months ago (2015-08-26 05:09:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312543003/40001
5 years, 3 months ago (2015-09-01 06:20:51 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 08:14:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201534

Powered by Google App Engine
This is Rietveld 408576698