Source/core/css/CSSPrimitiveValue.h - Issue 1312543003: Split out Attribute from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.h

Issue 1312543003: Split out Attribute from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@clean_up_get_string_value

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSPrimitiveValue.h

diff --git a/Source/core/css/CSSPrimitiveValue.h b/Source/core/css/CSSPrimitiveValue.h

index 521f87ed5ff68d75d3ae326e6e44240b37ccb04e..e17640e80ff619559fb69865c03262298119d478 100644

--- a/Source/core/css/CSSPrimitiveValue.h

+++ b/Source/core/css/CSSPrimitiveValue.h

@@ -89,7 +89,6 @@ public:

Kilohertz,

CustomIdentifier,

URI,

- Attribute,

RGBColor,

ViewportWidth,

ViewportHeight,

@@ -158,7 +157,6 @@ public:

|| type() == UnitType::Gradians

|| type() == UnitType::Turns;

}

- bool isAttr() const { return type() == UnitType::Attribute; }

bool isCustomIdent() const { return type() == UnitType::CustomIdentifier; }

bool isFontRelativeLength() const

{

« no previous file with comments | « Source/core/css/CSSCalculationValue.cpp ('k') | Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »