Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: Source/core/css/RuleFeature.cpp

Issue 1312543003: Split out Attribute from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@clean_up_get_string_value
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSPrimitiveValue.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 12 matching lines...) Expand all
23 * You should have received a copy of the GNU Library General Public License 23 * You should have received a copy of the GNU Library General Public License
24 * along with this library; see the file COPYING.LIB. If not, write to 24 * along with this library; see the file COPYING.LIB. If not, write to
25 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 25 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
26 * Boston, MA 02110-1301, USA. 26 * Boston, MA 02110-1301, USA.
27 */ 27 */
28 28
29 #include "config.h" 29 #include "config.h"
30 #include "core/css/RuleFeature.h" 30 #include "core/css/RuleFeature.h"
31 31
32 #include "core/HTMLNames.h" 32 #include "core/HTMLNames.h"
33 #include "core/css/CSSFunctionValue.h"
33 #include "core/css/CSSSelector.h" 34 #include "core/css/CSSSelector.h"
34 #include "core/css/CSSSelectorList.h" 35 #include "core/css/CSSSelectorList.h"
35 #include "core/css/CSSValueList.h" 36 #include "core/css/CSSValueList.h"
36 #include "core/css/RuleSet.h" 37 #include "core/css/RuleSet.h"
37 #include "core/css/StylePropertySet.h" 38 #include "core/css/StylePropertySet.h"
38 #include "core/css/StyleRule.h" 39 #include "core/css/StyleRule.h"
39 #include "core/css/invalidation/DescendantInvalidationSet.h" 40 #include "core/css/invalidation/DescendantInvalidationSet.h"
40 #include "core/dom/Element.h" 41 #include "core/dom/Element.h"
41 #include "core/dom/Node.h" 42 #include "core/dom/Node.h"
42 #include "core/inspector/InspectorTraceEvents.h" 43 #include "core/inspector/InspectorTraceEvents.h"
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 if (propertyIndex == -1) 304 if (propertyIndex == -1)
304 return; 305 return;
305 306
306 StylePropertySet::PropertyReference contentProperty = propertySet.propertyAt (propertyIndex); 307 StylePropertySet::PropertyReference contentProperty = propertySet.propertyAt (propertyIndex);
307 CSSValue* contentValue = contentProperty.value(); 308 CSSValue* contentValue = contentProperty.value();
308 309
309 if (!contentValue->isValueList()) 310 if (!contentValue->isValueList())
310 return; 311 return;
311 312
312 for (auto& item : toCSSValueList(*contentValue)) { 313 for (auto& item : toCSSValueList(*contentValue)) {
313 if (!item->isPrimitiveValue()) 314 if (!item->isFunctionValue())
314 continue; 315 continue;
315 CSSPrimitiveValue* primitiveItem = toCSSPrimitiveValue(item.get()); 316 CSSFunctionValue* functionValue = toCSSFunctionValue(item.get());
316 if (!primitiveItem->isAttr()) 317 if (functionValue->functionType() != CSSValueAttr)
317 continue; 318 continue;
318 ensureAttributeInvalidationSet(AtomicString(primitiveItem->getStringValu e())); 319 ensureAttributeInvalidationSet(AtomicString(toCSSPrimitiveValue(function Value->item(0))->getStringValue()));
319 } 320 }
320 } 321 }
321 322
322 std::pair<const CSSSelector*, RuleFeatureSet::UseFeaturesType> 323 std::pair<const CSSSelector*, RuleFeatureSet::UseFeaturesType>
323 RuleFeatureSet::extractInvalidationSetFeatures(const CSSSelector& selector, Inva lidationSetFeatures& features, bool negated) 324 RuleFeatureSet::extractInvalidationSetFeatures(const CSSSelector& selector, Inva lidationSetFeatures& features, bool negated)
324 { 325 {
325 bool foundFeatures = false; 326 bool foundFeatures = false;
326 for (const CSSSelector* current = &selector; current; current = current->tag History()) { 327 for (const CSSSelector* current = &selector; current; current = current->tag History()) {
327 if (!negated) 328 if (!negated)
328 foundFeatures |= extractInvalidationSetFeature(*current, features); 329 foundFeatures |= extractInvalidationSetFeature(*current, features);
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 visitor->trace(siblingRules); 583 visitor->trace(siblingRules);
583 visitor->trace(uncommonAttributeRules); 584 visitor->trace(uncommonAttributeRules);
584 visitor->trace(m_classInvalidationSets); 585 visitor->trace(m_classInvalidationSets);
585 visitor->trace(m_attributeInvalidationSets); 586 visitor->trace(m_attributeInvalidationSets);
586 visitor->trace(m_idInvalidationSets); 587 visitor->trace(m_idInvalidationSets);
587 visitor->trace(m_pseudoInvalidationSets); 588 visitor->trace(m_pseudoInvalidationSets);
588 #endif 589 #endif
589 } 590 }
590 591
591 } // namespace blink 592 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/CSSPrimitiveValue.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698