Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1312473012: PPC: [compiler] Remove broken support for undetectable strings. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [compiler] Remove broken support for undetectable strings. Port b62dbf1efdec68ae709b0e91d3b7c13171b720c9 Original commit message: Support for undetectable strings was officially dropped in https://codereview.chromium.org/916753002, but the compilers weren't fixed properly. R=bmeurer@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG= Committed: https://crrev.com/750b7f7a960ae129221d284e8454fb7860b31d25 Cr-Commit-Position: refs/heads/master@{#30390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-26 18:55:57 UTC) #1
john.yan
lgtm
5 years, 3 months ago (2015-08-26 19:10:50 UTC) #2
dstence
lgtm
5 years, 3 months ago (2015-08-26 19:22:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312473012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312473012/1
5 years, 3 months ago (2015-08-26 19:22:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 19:45:37 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 19:45:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/750b7f7a960ae129221d284e8454fb7860b31d25
Cr-Commit-Position: refs/heads/master@{#30390}

Powered by Google App Engine
This is Rietveld 408576698