Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 1312473012: PPC: [compiler] Remove broken support for undetectable strings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ppc/lithium-codegen-ppc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/ppc/full-codegen-ppc.cc
diff --git a/src/full-codegen/ppc/full-codegen-ppc.cc b/src/full-codegen/ppc/full-codegen-ppc.cc
index edcac11e3d368d4462a5afc555ee54bd6a47e5f9..ae6a2bd566590ac83c0a45ddf22478e17a6e77e4 100644
--- a/src/full-codegen/ppc/full-codegen-ppc.cc
+++ b/src/full-codegen/ppc/full-codegen-ppc.cc
@@ -4992,13 +4992,8 @@ void FullCodeGenerator::EmitLiteralCompareTypeof(Expression* expr,
Split(eq, if_true, if_false, fall_through);
} else if (String::Equals(check, factory->string_string())) {
__ JumpIfSmi(r3, if_false);
- // Check for undetectable objects => false.
__ CompareObjectType(r3, r3, r4, FIRST_NONSTRING_TYPE);
- __ bge(if_false);
- __ lbz(r4, FieldMemOperand(r3, Map::kBitFieldOffset));
- STATIC_ASSERT((1 << Map::kIsUndetectable) < 0x8000);
- __ andi(r0, r4, Operand(1 << Map::kIsUndetectable));
- Split(eq, if_true, if_false, fall_through, cr0);
+ Split(lt, if_true, if_false, fall_through);
} else if (String::Equals(check, factory->symbol_string())) {
__ JumpIfSmi(r3, if_false);
__ CompareObjectType(r3, r3, r4, SYMBOL_TYPE);
« no previous file with comments | « no previous file | src/ppc/lithium-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698