Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1312373002: Material PDF: Style audit and cleanup (Closed)

Created:
5 years, 4 months ago by tsergeant
Modified:
4 years ago
Reviewers:
raymes, Evan Stade
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dcheng, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material PDF: Style audit and cleanup This CL modifies styles across the PDF viewer to make them match the design mocks more closely, and cleans up and simplifies styles wherever possible. BUG=439114 TBR=estade@chromium.org Committed: https://crrev.com/f693f2575ec0a37917b1c8c429537d8634919c45 Cr-Commit-Position: refs/heads/master@{#345800}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Page selector tweaks #

Patch Set 5 : Fix tests for page selector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -72 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/shared-icon-style.css View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.css View 2 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css View 1 2 3 2 chunks +25 lines, -18 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.css View 1 4 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.css View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.css View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/pdf/index-material.css View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/pdf/material_elements_test.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
tsergeant
PTAL! This is a bit of a mixed bag of changes, so let me know ...
5 years, 4 months ago (2015-08-26 06:35:23 UTC) #2
raymes
lgtm https://codereview.chromium.org/1312373002/diff/40001/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html File chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html (right): https://codereview.chromium.org/1312373002/diff/40001/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html#newcode13 chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:13: / <span id="pagelength-inner">{{docLength}}</span> Maybe have 2 sibling spans ...
5 years, 3 months ago (2015-08-27 00:43:46 UTC) #3
tsergeant
Adding estade@ as TBR for trivial change to component_extension_resources.grd https://codereview.chromium.org/1312373002/diff/40001/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html File chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html (right): https://codereview.chromium.org/1312373002/diff/40001/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html#newcode13 chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:13: ...
5 years, 3 months ago (2015-08-27 02:52:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312373002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312373002/60001
5 years, 3 months ago (2015-08-27 02:53:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/95778)
5 years, 3 months ago (2015-08-27 03:24:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312373002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312373002/80001
5 years, 3 months ago (2015-08-27 03:33:23 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-08-27 05:09:25 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 05:09:58 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f693f2575ec0a37917b1c8c429537d8634919c45
Cr-Commit-Position: refs/heads/master@{#345800}

Powered by Google App Engine
This is Rietveld 408576698