chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js - Issue 1312373002: Material PDF: Style audit and cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

Issue 1312373002: Material PDF: Style audit and cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests for page selector Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html ('k') | chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

index 42dc22bb31774de4215b11c849da3e74aadabf6b..e731adf64527e2cf7baff5ee7eb86c65a1db7879 100644

--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

@@ -2,8 +2,6 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-var DIGIT_LENGTH = 0.6;

Polymer({

is: 'viewer-page-selector',

@@ -36,7 +34,10 @@ Polymer({

docLengthChanged: function() {

var numDigits = this.docLength.toString().length;

- this.$.pageselector.style.width = (numDigits * DIGIT_LENGTH) + 'em';

+ this.$.pageselector.style.width = numDigits + 'ch';

+ // Set both sides of the slash to the same width, so that the layout is

+ // exactly centered.

+ this.$['pagelength-spacer'].style.width = numDigits + 'ch';

select: function() {