chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html - Issue 1312373002: Material PDF: Style audit and cleanup

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

Issue 1312373002: Material PDF: Style audit and cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css ('k') | chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.h tml">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.h tml">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html">

4	4

5 <dom-module id="viewer-page-selector">	5 <dom-module id="viewer-page-selector">

6 <link rel="import" type="css" href="viewer-page-selector.css">	6 <link rel="import" type="css" href="viewer-page-selector.css">

7 <template>	7 <template>

8 <paper-input-container id="pageselector" no-label-float>	8 <paper-input-container id="pageselector" no-label-float>

9 <input id="input" is="iron-input" bind-value="{{pageNo}}" on-mouseup="sele ct"	9 <input id="input" is="iron-input" bind-value="{{pageNo}}" on-mouseup="sele ct"

10 on-change="pageNoCommitted">	10 on-change="pageNoCommitted">

11 </paper-input-container>	11 </paper-input-container>

12 <span id="pagelength">/ <span>{{docLength}}</span></span>	12 <span id="pagelength">

	13 / <span id="pagelength-inner">{{docLength}}</span>
	raymes 2015/08/27 00:43:46 Maybe have 2 sibling spans for the slash and the l Maybe have 2 sibling spans for the slash and the length tsergeant 2015/08/27 02:52:48 Done. It still uses an extra parent element for th Show quoted text On 2015/08/27 at 00:43:46, raymes wrote: > Maybe have 2 sibling spans for the slash and the length Done. It still uses an extra parent element for the length to help with spacing, but it's a nicer solution overall.
	14 </span>

13 </template>	15 </template>

14 </dom-module>	16 </dom-module>

15 <script src="viewer-page-selector.js"></script>	17 <script src="viewer-page-selector.js"></script>

OLD	NEW