Remove MediaStream label, ended attributes and stop() method

Remove MediaStream label, ended attributes and stop() method

Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LcZGlM9OBqs

Intent to Remove, which became an Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/s0UsMk8i2YM/WpepA4w3mPEJ

Depends on CL:
https://codereview.chromium.org/1344753002/
https://codereview.chromium.org/1349273003/

BUG=338500

[shiva.jm, 2015-08-26 10:39:10]

shiva.jm@samsung.com changed reviewers:
+ philipj@opera.com, tkent@chromium.org, tommi@chromium.org

[shiva.jm, 2015-08-26 10:39:11]

pls have a look. should we remove the code from counter.cpp file also?, which is
added in https://codereview.chromium.org/1194763002.
Should we report one more intent to remove or the existing one
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/remove/bl...
is fine ?

[philipj_slow, 2015-08-26 11:02:58]

On 2015/08/26 10:39:11, shiva.jm wrote:
> pls have a look. should we remove the code from counter.cpp file also?, which
is
> added in https://codereview.chromium.org/1194763002.
> Should we report one more intent to remove or the existing one
>
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/remove/bl...
> is fine ?

Yes, please also removed the entries from UseCounter.h and the deprecation
messages from UseCounter.cpp

[shiva.jm, 2015-08-27 06:24:06]

updated comments and raised new intent to remove.
pls have a look.

[philipj_slow, 2015-08-27 14:34:55]

tommi@, can you also take a look?

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/fast/medias...
File LayoutTests/fast/mediastream/MediaStream-onended.html (right):

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/fast/medias...
LayoutTests/fast/mediastream/MediaStream-onended.html:37: for (var i = 0; i <
s.getAudioTracks().length; i++)
If you know how many stream there are in this test, presumably just one audio
stream and one video stream, I think it'd be fine to just close those
explicitly, without the loop. Less code.

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/fast/medias...
File LayoutTests/fast/mediastream/MediaStreamConstructor.html (right):

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/fast/medias...
LayoutTests/fast/mediastream/MediaStreamConstructor.html:97: for (var i = 0; i <
s.getAudioTracks().length; i++)
Ditto.

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html
(right):

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html:4:
<title>getUserMedia({video:true}) creates a stream</title>
I'd like feedback from whoever wrote the test if this is still testing something
useful. It looks like al that's left is testing that the ended event is fired,
but perhaps that's already covered by some other test.

[shiva.jm, 2015-08-28 04:40:23]

updated tests, pls have a look.

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/fast/medias...
File LayoutTests/fast/mediastream/MediaStream-onended.html (right):

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/fast/medias...
LayoutTests/fast/mediastream/MediaStream-onended.html:37: for (var i = 0; i <
s.getAudioTracks().length; i++)
On 2015/08/27 14:34:54, philipj wrote:
> If you know how many stream there are in this test, presumably just one audio
> stream and one video stream, I think it'd be fine to just close those
> explicitly, without the loop. Less code.

Done.

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/fast/medias...
File LayoutTests/fast/mediastream/MediaStreamConstructor.html (right):

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/fast/medias...
LayoutTests/fast/mediastream/MediaStreamConstructor.html:97: for (var i = 0; i <
s.getAudioTracks().length; i++)
On 2015/08/27 14:34:54, philipj wrote:
> Ditto.

Done.

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html
(right):

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html:4:
<title>getUserMedia({video:true}) creates a stream</title>
On 2015/08/27 14:34:54, philipj wrote:
> I'd like feedback from whoever wrote the test if this is still testing
something
> useful. It looks like al that's left is testing that the ended event is fired,
> but perhaps that's already covered by some other test.

Yes, right already other test cover these test. shall we remove these entire
test?

[shiva.jm, 2015-08-31 03:52:15]

got 3 lgtm for intent post, pls have a look.

[tommi (sloooow) - chröme, 2015-08-31 07:31:06]

lgtm

+hta - fyi

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html
(right):

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html:4:
<title>getUserMedia({video:true}) creates a stream</title>
On 2015/08/28 04:40:23, shiva.jm wrote:
> On 2015/08/27 14:34:54, philipj wrote:
> > I'd like feedback from whoever wrote the test if this is still testing
> something
> > useful. It looks like al that's left is testing that the ended event is
fired,
> > but perhaps that's already covered by some other test.
> 
> Yes, right already other test cover these test. shall we remove these entire
> test?

Seems to have been added here:
https://chromium.googlesource.com/chromium/blink/+/ed2bde5a5fdf82704dd6d686b0...

[phoglund_chromium, 2015-08-31 08:56:01]

phoglund@chromium.org changed reviewers:
+ phoglund@chromium.org

[phoglund_chromium, 2015-08-31 08:56:02]

Note this will require updates to some tests:
https://code.google.com/p/chromium/codesearch#search/&q=stop%5C(%5C)%20getuse...
is all in Chromium, I think.

[shiva.jm, 2015-08-31 09:10:31]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 09:10:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312213006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312213006/60001

[commit-bot: I haz the power, 2015-08-31 09:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 09:48:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[philipj_slow, 2015-08-31 14:34:28]

The changes LG2M, but it sounds like there are tests in Chromium that need
fixing first?

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html
(right):

https://codereview.chromium.org/1312213006/diff/40001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html:4:
<title>getUserMedia({video:true}) creates a stream</title>
On 2015/08/31 07:31:06, tommi wrote:
> On 2015/08/28 04:40:23, shiva.jm wrote:
> > On 2015/08/27 14:34:54, philipj wrote:
> > > I'd like feedback from whoever wrote the test if this is still testing
> > something
> > > useful. It looks like al that's left is testing that the ended event is
> fired,
> > > but perhaps that's already covered by some other test.
> > 
> > Yes, right already other test cover these test. shall we remove these entire
> > test?
> 
> Seems to have been added here:
>
https://chromium.googlesource.com/chromium/blink/+/ed2bde5a5fdf82704dd6d686b0...

Shiva, did you take a look at this and compare to other tests? If you cannot
find anything unique that this test is still testing after the simplification,
then removing it is appropriate.

[shiva.jm, 2015-09-01 09:38:37]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-01 09:38:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312213006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312213006/60001

[commit-bot: I haz the power, 2015-09-01 10:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 10:26:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shiva.jm, 2015-09-02 05:15:09]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-02 05:15:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312213006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312213006/60001

[commit-bot: I haz the power, 2015-09-02 06:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 06:03:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shiva.jm, 2015-09-08 11:20:24]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-08 11:20:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312213006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312213006/60001

[commit-bot: I haz the power, 2015-09-08 12:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 12:05:14]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[shiva.jm, 2015-09-16 10:57:48]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-16 10:57:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312213006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312213006/80001

[commit-bot: I haz the power, 2015-09-16 11:43:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 11:43:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shiva.jm, 2015-09-19 04:51:43]

The CQ bit was checked by shiva.jm@samsung.com

[shiva.jm, 2015-09-19 04:51:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1312213006/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-09-19 04:51:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312213006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312213006/80001

[commit-bot: I haz the power, 2015-09-19 04:56:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-19 04:56:13]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shiva.jm, 2015-09-24 01:04:14]

The CQ bit was checked by shiva.jm@samsung.com

[commit-bot: I haz the power, 2015-09-24 01:04:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312213006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312213006/80001

[commit-bot: I haz the power, 2015-09-24 01:05:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 01:05:48]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)