Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1194763002: Deprecate MediaStream label, ended attributes and stop() method (Closed)

Created:
5 years, 6 months ago by shiva.jm
Modified:
5 years, 6 months ago
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Deprecate MediaStream label, ended attributes and stop() method Intent to Remove, which became an Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/s0UsMk8i2YM/WpepA4w3mPEJ BUG=338500 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197742

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M LayoutTests/fast/mediastream/MediaStream-onended-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStream.idl View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
shiva.jm
As discussed on these thread:https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0UsMk8i2YM, we should deprecate these before removing. pls have a look.
5 years, 6 months ago (2015-06-19 05:22:02 UTC) #2
Habib Virji
https://codereview.chromium.org/1194763002/diff/1/LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt File LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt (right): https://codereview.chromium.org/1194763002/diff/1/LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt#newcode1 LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt:1: CONSOLE WARNING: 'MediaStream.stop()' is deprecated, after adding MediaStream.active attribute, ...
5 years, 6 months ago (2015-06-23 08:58:21 UTC) #4
shiva.jm
Updated the review comments, pls have a look. https://codereview.chromium.org/1194763002/diff/1/LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt File LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt (right): https://codereview.chromium.org/1194763002/diff/1/LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt#newcode1 LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt:1: CONSOLE ...
5 years, 6 months ago (2015-06-24 09:59:31 UTC) #5
philipj_slow
Please create a tracking bug for deprecating and removing these, or perhaps reuse issue 338500 ...
5 years, 6 months ago (2015-06-24 10:15:01 UTC) #6
philipj_slow
https://codereview.chromium.org/1194763002/diff/20001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1194763002/diff/20001/Source/core/frame/UseCounter.cpp#newcode942 Source/core/frame/UseCounter.cpp:942: return "'MediaStream.label' is deprecated. See http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream for more details."; ...
5 years, 6 months ago (2015-06-24 10:18:17 UTC) #7
shiva.jm
On 2015/06/24 10:15:01, philipj wrote: > Please create a tracking bug for deprecating and removing ...
5 years, 6 months ago (2015-06-24 10:18:20 UTC) #8
shiva.jm
Updated the review comments. pls have a look. https://codereview.chromium.org/1194763002/diff/20001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1194763002/diff/20001/Source/core/frame/UseCounter.cpp#newcode942 Source/core/frame/UseCounter.cpp:942: return ...
5 years, 6 months ago (2015-06-24 12:06:42 UTC) #9
philipj_slow
LGTM, but let's also give module owner tommi@ the final word.
5 years, 6 months ago (2015-06-24 12:09:35 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194763002/40001
5 years, 6 months ago (2015-06-24 12:11:45 UTC) #13
tommi (sloooow) - chröme
lgtm Thanks philipj.
5 years, 6 months ago (2015-06-24 12:17:38 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-24 14:50:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194763002/40001
5 years, 6 months ago (2015-06-24 15:02:45 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 15:07:42 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197742

Powered by Google App Engine
This is Rietveld 408576698