Deprecate MediaStream label, ended attributes and stop() method

Deprecate MediaStream label, ended attributes and stop() method

Intent to Remove, which became an Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/s0UsMk8i2YM/WpepA4w3mPEJ

BUG=338500
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197742

[shiva.jm, 2015-06-19 05:22:01]

shiva.jm@samsung.com changed reviewers:
+ philipj@opera.com, tkent@chromium.org

[shiva.jm, 2015-06-19 05:22:02]

As discussed on these
thread:https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s0UsMk8i2YM,
we should deprecate these before removing. pls have a look.

[Habib Virji, 2015-06-23 08:58:20]

habib.virji@samsung.com changed reviewers:
+ habib.virji@samsung.com

[Habib Virji, 2015-06-23 08:58:21]

https://codereview.chromium.org/1194763002/diff/1/LayoutTests/fast/mediastrea...
File LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt (right):

https://codereview.chromium.org/1194763002/diff/1/LayoutTests/fast/mediastrea...
LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt:1: CONSOLE
WARNING: 'MediaStream.stop()' is deprecated, after adding MediaStream.active
attribute, please do not use it. as per spec
(http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).
This will change if you update UseCounter..

https://codereview.chromium.org/1194763002/diff/1/Source/core/frame/UseCounte...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1194763002/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:939: return "'MediaStream.label' is deprecated,
please do not use it. as per spec
(http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
Would suggest rewording this to: "'MediaStream.label' is deprecated. See
http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream for
more details.";

Also not sure if link is useful as label is not mentioned in the spec as being
deprecated.

https://codereview.chromium.org/1194763002/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:941: return "'MediaStream.stop()' is
deprecated, after adding MediaStream.active attribute, please do not use it. as
per spec
(http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
"'MediaStream.stop()' is deprecated. Please use MediaStream.active attribute
instead."; 

The spec link does not mention anything about stop(). Not sure if the link is an
aid here.

https://codereview.chromium.org/1194763002/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:943: return "'MediaStream.ended' is deprecated,
after adding MediaStream.active attribute, please do not use it. as per spec
(http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
Same as above comments.

[shiva.jm, 2015-06-24 09:59:31]

Updated the review comments, pls have a look.

https://codereview.chromium.org/1194763002/diff/1/LayoutTests/fast/mediastrea...
File LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt (right):

https://codereview.chromium.org/1194763002/diff/1/LayoutTests/fast/mediastrea...
LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt:1: CONSOLE
WARNING: 'MediaStream.stop()' is deprecated, after adding MediaStream.active
attribute, please do not use it. as per spec
(http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).
On 2015/06/23 08:58:21, Habib Virji wrote:
> This will change if you update UseCounter..

Done.

https://codereview.chromium.org/1194763002/diff/1/Source/core/frame/UseCounte...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1194763002/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:939: return "'MediaStream.label' is deprecated,
please do not use it. as per spec
(http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
On 2015/06/23 08:58:21, Habib Virji wrote:
> Would suggest rewording this to: "'MediaStream.label' is deprecated. See
> http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream
for
> more details.";
> 
> Also not sure if link is useful as label is not mentioned in the spec as being
> deprecated.

Done.

https://codereview.chromium.org/1194763002/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:941: return "'MediaStream.stop()' is
deprecated, after adding MediaStream.active attribute, please do not use it. as
per spec
(http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
On 2015/06/23 08:58:21, Habib Virji wrote:
> "'MediaStream.stop()' is deprecated. Please use MediaStream.active attribute
> instead."; 
> 
> The spec link does not mention anything about stop(). Not sure if the link is
an
> aid here. 

Done.

https://codereview.chromium.org/1194763002/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:943: return "'MediaStream.ended' is deprecated,
after adding MediaStream.active attribute, please do not use it. as per spec
(http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
On 2015/06/23 08:58:21, Habib Virji wrote:
> Same as above comments.

Done.

[philipj_slow, 2015-06-24 10:15:01]

Please create a tracking bug for deprecating and removing these, or perhaps
reuse issue 338500 to cover all of it.

[philipj_slow, 2015-06-24 10:18:17]

https://codereview.chromium.org/1194763002/diff/20001/Source/core/frame/UseCo...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1194763002/diff/20001/Source/core/frame/UseCo...
Source/core/frame/UseCounter.cpp:942: return "'MediaStream.label' is deprecated.
See http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream
for more details.";
Please add a blank line after every return like above in this file.

I think that we should set a date for the removal so that people know to take it
seriously. If this lands this week the deprecation will be in M45, and two
release cycles ought to be enough, so removal in M47. In other words, this
message:
"'MediaStream.label' is deprecated and will be removed in M47, around November
2015. Please use 'MediaStream.id' instead.";

And similarly for the below.

[shiva.jm, 2015-06-24 10:18:20]

On 2015/06/24 10:15:01, philipj wrote:
> Please create a tracking bug for deprecating and removing these, or perhaps
> reuse issue 338500 to cover all of it.

Thanks, updated the bug to use 338500 to cover these issue also.

[shiva.jm, 2015-06-24 12:06:42]

Updated the review comments. pls have a look.

https://codereview.chromium.org/1194763002/diff/20001/Source/core/frame/UseCo...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1194763002/diff/20001/Source/core/frame/UseCo...
Source/core/frame/UseCounter.cpp:942: return "'MediaStream.label' is deprecated.
See http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream
for more details.";
On 2015/06/24 10:18:17, philipj wrote:
> Please add a blank line after every return like above in this file.
> 
> I think that we should set a date for the removal so that people know to take
it
> seriously. If this lands this week the deprecation will be in M45, and two
> release cycles ought to be enough, so removal in M47. In other words, this
> message:
> "'MediaStream.label' is deprecated and will be removed in M47, around November
> 2015. Please use 'MediaStream.id' instead.";
> 
> And similarly for the below.

Done.

[philipj_slow, 2015-06-24 12:09:34]

philipj@opera.com changed reviewers:
+ tommi@chromium.org

[philipj_slow, 2015-06-24 12:09:35]

LGTM, but let's also give module owner tommi@ the final word.

[philipj_slow, 2015-06-24 12:11:35]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-24 12:11:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194763002/40001

[tommi (sloooow) - chröme, 2015-06-24 12:17:38]

lgtm

Thanks philipj.

[commit-bot: I haz the power, 2015-06-24 14:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-24 14:50:49]

Dry run: This issue passed the CQ dry run.

[philipj_slow, 2015-06-24 15:02:19]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-06-24 15:02:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194763002/40001

[commit-bot: I haz the power, 2015-06-24 15:07:42]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197742