LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html - Issue 1312213006: Remove MediaStream label, ended attributes and stop() method

Side by Side Diff: LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html

Issue 1312213006: Remove MediaStream label, ended attributes and stop() method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/mediastream/MediaStreamConstructor.html ('K') | « LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt ('k') | LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>getUserMedia({video:true}) creates a stream with ended set to false</titl e>	4 <title>getUserMedia({video:true}) creates a stream</title>
	philipj_slow 2015/08/27 14:34:54 I'd like feedback from whoever wrote the test if t I'd like feedback from whoever wrote the test if this is still testing something useful. It looks like al that's left is testing that the ended event is fired, but perhaps that's already covered by some other test. shiva.jm 2015/08/28 04:40:23 Yes, right already other test cover these test. sh Show quoted text On 2015/08/27 14:34:54, philipj wrote: > I'd like feedback from whoever wrote the test if this is still testing something > useful. It looks like al that's left is testing that the ended event is fired, > but perhaps that's already covered by some other test. Yes, right already other test cover these test. shall we remove these entire test? tommi (sloooow) - chröme 2015/08/31 07:31:06 Seems to have been added here: https://chromium.go Show quoted text On 2015/08/28 04:40:23, shiva.jm wrote: > On 2015/08/27 14:34:54, philipj wrote: > > I'd like feedback from whoever wrote the test if this is still testing > something > > useful. It looks like al that's left is testing that the ended event is fired, > > but perhaps that's already covered by some other test. > > Yes, right already other test cover these test. shall we remove these entire > test? Seems to have been added here: https://chromium.googlesource.com/chromium/blink/+/ed2bde5a5fdf82704dd6d686b0... philipj_slow 2015/08/31 14:34:28 Shiva, did you take a look at this and compare to Show quoted text On 2015/08/31 07:31:06, tommi wrote: > On 2015/08/28 04:40:23, shiva.jm wrote: > > On 2015/08/27 14:34:54, philipj wrote: > > > I'd like feedback from whoever wrote the test if this is still testing > > something > > > useful. It looks like al that's left is testing that the ended event is > fired, > > > but perhaps that's already covered by some other test. > > > > Yes, right already other test cover these test. shall we remove these entire > > test? > > Seems to have been added here: > https://chromium.googlesource.com/chromium/blink/+/ed2bde5a5fdf82704dd6d686b0... Shiva, did you take a look at this and compare to other tests? If you cannot find anything unique that this test is still testing after the simplification, then removing it is appropriate.
5 <link rel="author" title="Dominique Hazael-Massieux" href="mailto:dom@w3.org"/>	5 <link rel="author" title="Dominique Hazael-Massieux" href="mailto:dom@w3.org"/>

6 <link rel="help" href="http://dev.w3.org/2011/webrtc/editor/getusermedia.html#wi dl-MediaStream-ended">	6 <link rel="help" href="http://dev.w3.org/2011/webrtc/editor/getusermedia.html#wi dl-MediaStream-ended">

7 <link rel="help" href="http://dev.w3.org/2011/webrtc/editor/getusermedia.html#ev ent-mediastream-ended">	7 <link rel="help" href="http://dev.w3.org/2011/webrtc/editor/getusermedia.html#ev ent-mediastream-ended">

8 <link rel='stylesheet' href='../../../../../resources/testharness.css' media='al l'/>	8 <link rel='stylesheet' href='../../../../../resources/testharness.css' media='al l'/>

9 </head>	9 </head>

10 <body>	10 <body>

11 <p class="instructions" style="display:none">When prompted, accept to share your video stream.</p>	11 <p class="instructions" style="display:none">When prompted, accept to share your video stream.</p>

12 <h1 class="instructions" style="display:none">Description</h1>	12 <h1 class="instructions" style="display:none">Description</h1>

13 <p class="instructions" style="display:none">This test checks that the MediaStre am object returned by	13 <p class="instructions" style="display:none">This test checks that the MediaStre am object returned by

14 the success callback in getUserMedia has a ended set to false at start, and	14 the success callback in getUserMedia handles onended correctly.</p>

15 triggers "onended" when it is set to true.</p>

16	15

17 <div id='log'></div>	16 <div id='log'></div>

18 <script src=../../../../../resources/testharness.js></script>	17 <script src=../../../../../resources/testharness.js></script>

19 <script src=../../../../../resources/testharnessreport.js></script>	18 <script src=../../../../../resources/testharnessreport.js></script>

20 <script src="../../../../../resources/vendor-prefix.js" data-prefixed-objects='[ {"ancestors":["navigator"], "name":"getUserMedia"}]'></script>	19 <script src="../../../../../resources/vendor-prefix.js" data-prefixed-objects='[ {"ancestors":["navigator"], "name":"getUserMedia"}]'></script>

21 <script>	20 <script>

22 var t = async_test("Tests that a MediaStream handles ended correctly", {timeout: 10000});	21 var t = async_test("Tests that a MediaStream handles onended correctly", {timeou t:10000});

23 t.step(function () {	22 t.step(function () {

24 navigator.getUserMedia({video:true}, t.step_func(function (stream) {	23 navigator.getUserMedia({video:true}, t.step_func(function (stream) {

25 assert_true(!stream.ended, "the media stream starts with ended set to false" );

26 stream.addEventListener("ended", t.step_func(function() {	24 stream.addEventListener("ended", t.step_func(function() {

27 assert_true(stream.ended, "stream.ended now set to true");

28 t.done();	25 t.done();

29 }), false);	26 }), false);

30 stream.ended = true;

31 assert_true(!stream.ended, "stream.ended should remain false");

32 stream.getVideoTracks()[0].stop();	27 stream.getVideoTracks()[0].stop();

33 }), function (error) {});	28 }), function (error) {});

34 });	29 });

35 </script>	30 </script>

36 </body>	31 </body>

37 </html>	32 </html>

OLD	NEW