Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1312203004: Revert of Add documentation to 2 DeprecatedPaintLayer objects (Closed)

Created:
5 years, 3 months ago by RobertoCN
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add documentation to 2 DeprecatedPaintLayer objects (patchset #2 id:20001 of https://codereview.chromium.org/1327483003/ ) Reason for revert: Speculative revert: Failed build job. I don't know why a comment would cause a breakage but the build output shows: In file included from ../../third_party/WebKit/Source/core/paint/DeprecatedPaintLayer.h:50:0, from ../../third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp:39: ../../third_party/WebKit/Source/core/paint/DeprecatedPaintLayerClipper.h:135:1:error: multi-line comment [-Werror=comment] // / \ ^ Original issue's description: > Add documentation to 2 DeprecatedPaintLayer objects > > Added class level comments to DeprecatedPaintLayerClipper > and DeprecatedPaintLayerStackingNode. > > While touching DeprecatedPaintLayerStackingNode, added a comment > about NormalFlowChildren. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201805 TBR=eae@chromium.org,mstensho@opera.com,wkorman@chromium.org,jchaffraix@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -85 lines) Patch
M Source/core/paint/DeprecatedPaintLayer.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.h View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNode.h View 1 chunk +0 lines, -27 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNodeIterator.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
RobertoCN
Created Revert of Add documentation to 2 DeprecatedPaintLayer objects
5 years, 3 months ago (2015-09-04 17:47:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312203004/1
5 years, 3 months ago (2015-09-04 17:47:57 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 17:48:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201809

Powered by Google App Engine
This is Rietveld 408576698