Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayer.h

Issue 1312203004: Revert of Add documentation to 2 DeprecatedPaintLayer objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/paint/DeprecatedPaintLayerClipper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 TemporaryChange<CompositingQueryMode> m_disabler; 88 TemporaryChange<CompositingQueryMode> m_disabler;
89 }; 89 };
90 90
91 // DeprecatedPaintLayer is an old object that handles lots of unrelated operatio ns. 91 // DeprecatedPaintLayer is an old object that handles lots of unrelated operatio ns.
92 // We want it to die at some point and be replaced by more focused objects. Remo ving 92 // We want it to die at some point and be replaced by more focused objects. Remo ving
93 // a lot of unneeded complexity. 93 // a lot of unneeded complexity.
94 // Complex painting operations (opacity, clipping, filters, reflections, ...), 94 // Complex painting operations (opacity, clipping, filters, reflections, ...),
95 // hardware acceleration (through DeprecatedPaintLayerCompositor), 95 // hardware acceleration (through DeprecatedPaintLayerCompositor),
96 // scrolling (through DeprecatedPaintLayerScrollableArea) 96 // scrolling (through DeprecatedPaintLayerScrollableArea)
97 // along with some optimizations are all handled by DeprecatedPaintLayer. 97 // along with some optimizations are all handled by DeprecatedPaintLayer.
98 //
99 // The class is DEPRECATED, which means that we would like to remove it. The
100 // reason for removal is that it has been a dumping ground for features for too
101 // long and is the wrong level of abstraction, bearing no correspondence to any
102 // CSS concept. Its associated objects and some of its feature need to be
103 // migrated to LayoutObject (or the appropriate sub-class).
104 class CORE_EXPORT DeprecatedPaintLayer { 98 class CORE_EXPORT DeprecatedPaintLayer {
105 WTF_MAKE_NONCOPYABLE(DeprecatedPaintLayer); 99 WTF_MAKE_NONCOPYABLE(DeprecatedPaintLayer);
106 public: 100 public:
107 DeprecatedPaintLayer(LayoutBoxModelObject*, DeprecatedPaintLayerType); 101 DeprecatedPaintLayer(LayoutBoxModelObject*, DeprecatedPaintLayerType);
108 ~DeprecatedPaintLayer(); 102 ~DeprecatedPaintLayer();
109 103
110 String debugName() const; 104 String debugName() const;
111 105
112 LayoutBoxModelObject* layoutObject() const { return m_layoutObject; } 106 LayoutBoxModelObject* layoutObject() const { return m_layoutObject; }
113 LayoutBox* layoutBox() const { return m_layoutObject && m_layoutObject->isBo x() ? toLayoutBox(m_layoutObject) : 0; } 107 LayoutBox* layoutBox() const { return m_layoutObject && m_layoutObject->isBo x() ? toLayoutBox(m_layoutObject) : 0; }
(...skipping 629 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 737
744 } // namespace blink 738 } // namespace blink
745 739
746 #ifndef NDEBUG 740 #ifndef NDEBUG
747 // Outside the WebCore namespace for ease of invocation from gdb. 741 // Outside the WebCore namespace for ease of invocation from gdb.
748 void showLayerTree(const blink::DeprecatedPaintLayer*); 742 void showLayerTree(const blink::DeprecatedPaintLayer*);
749 void showLayerTree(const blink::LayoutObject*); 743 void showLayerTree(const blink::LayoutObject*);
750 #endif 744 #endif
751 745
752 #endif // Layer_h 746 #endif // Layer_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/paint/DeprecatedPaintLayerClipper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698