Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: Source/core/paint/DeprecatedPaintLayerClipper.h

Issue 1312203004: Revert of Add documentation to 2 DeprecatedPaintLayer objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayer.h ('k') | Source/core/paint/DeprecatedPaintLayerStackingNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/DeprecatedPaintLayerClipper.h
diff --git a/Source/core/paint/DeprecatedPaintLayerClipper.h b/Source/core/paint/DeprecatedPaintLayerClipper.h
index de06b937d63c8502981d9e194ef4eb88c2173d9f..a0303716c08c6eb070bd53d13e5d246f8d256bca 100644
--- a/Source/core/paint/DeprecatedPaintLayerClipper.h
+++ b/Source/core/paint/DeprecatedPaintLayerClipper.h
@@ -127,54 +127,6 @@
ShouldRespectOverflowClip respectOverflowClipForViewport;
};
-// DeprecatedPaintLayerClipper is responsible for computing and caching clip
-// rects.
-//
-// The main reason for this cache is that we compute the clip rects during
-// a layout tree walk but need them during a paint tree walk (see example
-// below for some explanations).
-//
-// A lot of complexity in this class come from the difference in inheritance
-// between 'overflow' and 'clip':
-// * 'overflow' applies based on the containing blocks chain.
-// (http://www.w3.org/TR/CSS2/visufx.html#propdef-overflow)
-// * 'clip' applies to all descendants.
-// (http://www.w3.org/TR/CSS2/visufx.html#propdef-clip)
-//
-// Let's take an example:
-// <!DOCTYPE html>
-// <div id="container" style="position: absolute; height: 100px; width: 100px">
-// <div id="inflow" style="height: 200px; width: 200px;
-// background-color: purple"></div>
-// <div id="fixed" style="height: 200px; width: 200px; position: fixed;
-// background-color: orange"></div>
-// </div>
-//
-// The paint tree looks like:
-// html
-// / \
-// / \
-// / \
-// container fixed
-// |
-// |
-// inflow
-//
-// If we add "overflow: hidden" to #container, the overflow clip will apply to
-// #inflow but not to #fixed. That's because #fixed's containing block is above
-// #container and thus 'overflow' doesn't apply to it. During our tree walk,
-// #fixed is a child of #container, which is the reason why we keep 3 clip rects
-// depending on the 'position' of the elements.
-//
-// Now instead if we add "clip: rect(0px, 100px, 100px, 0px)" to #container,
-// the clip will apply to both #inflow and #fixed. That's because 'clip'
-// applies to any descendant, regardless of containing blocks. Note that
-// #container and #fixed are siblings in the paint tree but #container does
-// clip #fixed. This is the reason why we compute the painting clip rects during
-// a layout tree walk and cache them for painting.
-//
-// This class is NOT DEPRECATED, DeprecatedPaintLayer is and we match its
-// naming.
class DeprecatedPaintLayerClipper {
DISALLOW_ALLOCATION();
WTF_MAKE_NONCOPYABLE(DeprecatedPaintLayerClipper);
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayer.h ('k') | Source/core/paint/DeprecatedPaintLayerStackingNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698