Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1312193002: Android NTP: Most visited tile clicks should have PageTransition.AUTO_BOOKMARK (Closed)

Created:
5 years, 4 months ago by Marc Treib
Modified:
5 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@filename_from_finch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android NTP: Most visited tile clicks should have PageTransition.AUTO_BOOKMARK This is necessary so that clicks on popular suggestions will create TopSites entries. It also brings the Android NTP in line with desktop. BUG=516618 Committed: https://crrev.com/f1066fd4f2e805994a562a8e5e2cd332032ebc67 Cr-Commit-Position: refs/heads/master@{#345338}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 2 chunks +7 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Marc Treib
PTAL! Code links for context: Corresponding desktop code that sets AUTO_BOOKMARK: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/browser.cc&l=1938 PageTransition filter in ...
5 years, 4 months ago (2015-08-25 14:22:58 UTC) #2
Bernhard Bauer
lgtm
5 years, 4 months ago (2015-08-25 14:26:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312193002/1
5 years, 4 months ago (2015-08-25 14:28:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/24121) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-25 14:30:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312193002/20001
5 years, 4 months ago (2015-08-25 14:43:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-25 15:53:36 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 15:54:17 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1066fd4f2e805994a562a8e5e2cd332032ebc67
Cr-Commit-Position: refs/heads/master@{#345338}

Powered by Google App Engine
This is Rietveld 408576698