Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1302773002: Popular sites on the NTP: add the option to provide the server filename through a variation param (Closed)

Created:
5 years, 4 months ago by Marc Treib
Modified:
5 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Popular sites on the NTP: add the option to provide the server filename through a variation param BUG=516618 Committed: https://crrev.com/508939ad76f6a94aa5575e2fc37ce47458cd2051 Cr-Commit-Position: refs/heads/master@{#345296}

Patch Set 1 #

Patch Set 2 : redownload on filename change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M chrome/browser/android/most_visited_sites.cc View 4 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/android/popular_sites.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/popular_sites.cc View 1 3 chunks +18 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Marc Treib
PTAL!
5 years, 4 months ago (2015-08-20 11:28:35 UTC) #2
Bernhard Bauer
lgtm
5 years, 4 months ago (2015-08-25 09:43:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302773002/20001
5 years, 4 months ago (2015-08-25 09:48:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/24091) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-25 09:52:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302773002/20001
5 years, 4 months ago (2015-08-25 10:01:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-25 10:08:04 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 10:08:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/508939ad76f6a94aa5575e2fc37ce47458cd2051
Cr-Commit-Position: refs/heads/master@{#345296}

Powered by Google App Engine
This is Rietveld 408576698