Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1312193002: Android NTP: Most visited tile clicks should have PageTransition.AUTO_BOOKMARK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filename_from_finch
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 2c15bb1df75bfa9c97f85a2468681dd863915b0c..3cf4e88f610248a87e309ec056cf0ccc6250fe39 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -235,7 +235,7 @@ public class NewTabPage
public void open(MostVisitedItem item) {
if (mIsDestroyed) return;
recordOpenedMostVisitedItem(item);
- mTab.loadUrl(new LoadUrlParams(item.getUrl()));
+ mTab.loadUrl(new LoadUrlParams(item.getUrl(), PageTransition.AUTO_BOOKMARK));
}
@Override
@@ -258,13 +258,15 @@ public class NewTabPage
switch (menuId) {
case ID_OPEN_IN_NEW_TAB:
recordOpenedMostVisitedItem(item);
- mTabModelSelector.openNewTab(new LoadUrlParams(item.getUrl()),
- TabLaunchType.FROM_LONGPRESS_BACKGROUND, mTab, false);
+ mTabModelSelector.openNewTab(new LoadUrlParams(item.getUrl(),
+ PageTransition.AUTO_BOOKMARK), TabLaunchType.FROM_LONGPRESS_BACKGROUND,
+ mTab, false);
return true;
case ID_OPEN_IN_INCOGNITO_TAB:
recordOpenedMostVisitedItem(item);
- mTabModelSelector.openNewTab(new LoadUrlParams(item.getUrl()),
- TabLaunchType.FROM_LONGPRESS_FOREGROUND, mTab, true);
+ mTabModelSelector.openNewTab(new LoadUrlParams(item.getUrl(),
+ PageTransition.AUTO_BOOKMARK), TabLaunchType.FROM_LONGPRESS_FOREGROUND,
+ mTab, true);
return true;
case ID_REMOVE:
mMostVisitedSites.blacklistUrl(item.getUrl());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698