components/service_tab_launcher/browser/android/service_tab_launcher.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/service_tab_launcher/browser/android/service_tab_launcher.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/safe_json/json_sanitizer_android.cc ('k') | components/signin/core/browser/child_account_info_fetcher_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/service_tab_launcher/browser/android/service_tab_launcher.cc

diff --git a/components/service_tab_launcher/browser/android/service_tab_launcher.cc b/components/service_tab_launcher/browser/android/service_tab_launcher.cc

index 7a1bc0f9ada5c328726476faf704b2d3846b48e8..8408e6b606e67bc2caf7702af73dae4ddf20b1be 100644

--- a/components/service_tab_launcher/browser/android/service_tab_launcher.cc

+++ b/components/service_tab_launcher/browser/android/service_tab_launcher.cc

@@ -17,7 +17,10 @@ using base::android::GetApplicationContext;

// Called by Java when the WebContents instance for a request Id is available.

void OnWebContentsForRequestAvailable(

- JNIEnv* env, jclass clazz, jint request_id, jobject android_web_contents) {

+ JNIEnv* env,

+ const JavaParamRef<jclass>& clazz,

+ jint request_id,

+ const JavaParamRef<jobject>& android_web_contents) {

service_tab_launcher::ServiceTabLauncher::GetInstance()->OnTabLaunched(

request_id,

content::WebContents::FromJavaWebContents(android_web_contents));