components/safe_json/json_sanitizer_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_json/json_sanitizer_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/core/url_utils_android.cc ('k') | components/service_tab_launcher/browser/android/service_tab_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_json/json_sanitizer_android.cc

diff --git a/components/safe_json/json_sanitizer_android.cc b/components/safe_json/json_sanitizer_android.cc

index 9ccad08f6c9d6966cabb818d07756c1cb0b149ca..7b07d21891158ed55f58ffd24e97fa80fb626fa0 100644

--- a/components/safe_json/json_sanitizer_android.cc

+++ b/components/safe_json/json_sanitizer_android.cc

@@ -84,13 +84,19 @@ void JsonSanitizerAndroid::OnError(const std::string& error) {

} // namespace

-void OnSuccess(JNIEnv* env, jclass clazz, jlong jsanitizer, jstring json) {

+void OnSuccess(JNIEnv* env,

+ const JavaParamRef<jclass>& clazz,

+ jlong jsanitizer,

+ const JavaParamRef<jstring>& json) {

JsonSanitizerAndroid* sanitizer =

reinterpret_cast<JsonSanitizerAndroid*>(jsanitizer);

sanitizer->OnSuccess(base::android::ConvertJavaStringToUTF8(env, json));

}

-void OnError(JNIEnv* env, jclass clazz, jlong jsanitizer, jstring error) {

+void OnError(JNIEnv* env,

+ const JavaParamRef<jclass>& clazz,

+ jlong jsanitizer,

+ const JavaParamRef<jstring>& error) {

JsonSanitizerAndroid* sanitizer =

reinterpret_cast<JsonSanitizerAndroid*>(jsanitizer);

sanitizer->OnError(base::android::ConvertJavaStringToUTF8(env, error));