components/signin/core/browser/child_account_info_fetcher_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/child_account_info_fetcher_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/service_tab_launcher/browser/android/service_tab_launcher.cc ('k') | components/variations/android/variations_associated_data_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/child_account_info_fetcher_android.cc

diff --git a/components/signin/core/browser/child_account_info_fetcher_android.cc b/components/signin/core/browser/child_account_info_fetcher_android.cc

index 8b30e12c6c0a23073050c20fd31cdef925e2668f..39ec8c460443a7091d5c0ea47f2013264590ef94 100644

--- a/components/signin/core/browser/child_account_info_fetcher_android.cc

+++ b/components/signin/core/browser/child_account_info_fetcher_android.cc

@@ -33,9 +33,9 @@ bool ChildAccountInfoFetcherAndroid::Register(JNIEnv* env) {

}

void SetIsChildAccount(JNIEnv* env,

- jclass caller,

+ const JavaParamRef<jclass>& caller,

jlong native_service,

- jstring j_account_id,

+ const JavaParamRef<jstring>& j_account_id,

jboolean is_child_account) {

AccountFetcherService* service =

reinterpret_cast<AccountFetcherService*>(native_service);