components/cronet/android/test/test_upload_data_stream_handler.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/test_upload_data_stream_handler.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/sdch_test_util.cc ('k') | components/dom_distiller/content/browser/distillable_page_utils_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/test_upload_data_stream_handler.cc

diff --git a/components/cronet/android/test/test_upload_data_stream_handler.cc b/components/cronet/android/test/test_upload_data_stream_handler.cc

index 1c3e68327ab72129fcb8595ca95fc16ca51144c0..5658e9e1dd45eddd69671eed5a91cd4686ae747a 100644

--- a/components/cronet/android/test/test_upload_data_stream_handler.cc

+++ b/components/cronet/android/test/test_upload_data_stream_handler.cc

@@ -169,7 +169,7 @@ void TestUploadDataStreamHandler::NotifyJavaReadCompleted() {

static jlong CreateTestUploadDataStreamHandler(

JNIEnv* env,

- jobject jtest_upload_data_stream_handler,

+ const JavaParamRef<jobject>& jtest_upload_data_stream_handler,

jlong jupload_data_stream) {

scoped_ptr<net::UploadDataStream> upload_data_stream(

reinterpret_cast<net::UploadDataStream*>(jupload_data_stream));