Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: components/cronet/android/test/sdch_test_util.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/sdch_test_util.cc
diff --git a/components/cronet/android/test/sdch_test_util.cc b/components/cronet/android/test/sdch_test_util.cc
index e794e253a51f146038c918cc8fd11022259eaf8a..1aef4804889b77a90ce7c7338dfcc8ae7842614c 100644
--- a/components/cronet/android/test/sdch_test_util.cc
+++ b/components/cronet/android/test/sdch_test_util.cc
@@ -100,8 +100,8 @@ void AddSdchObserverOnNetworkThreadLegacyAPI(
} // namespace
void AddSdchObserver(JNIEnv* env,
- jobject jsdch_observer,
- jstring jtarget_url,
+ const JavaParamRef<jobject>& jsdch_observer,
+ const JavaParamRef<jstring>& jtarget_url,
jlong jadapter) {
base::android::ScopedJavaGlobalRef<jobject> jsdch_observer_ref;
// ScopedJavaGlobalRef do not hold onto the env reference, so it is safe to
@@ -119,8 +119,8 @@ void AddSdchObserver(JNIEnv* env,
}
void AddSdchObserverLegacyAPI(JNIEnv* env,
- jobject jsdch_observer,
- jstring jtarget_url,
+ const JavaParamRef<jobject>& jsdch_observer,
+ const JavaParamRef<jstring>& jtarget_url,
jlong jadapter) {
base::android::ScopedJavaGlobalRef<jobject> jsdch_observer_ref;
// ScopedJavaGlobalRef do not hold onto the env reference, so it is safe to
« no previous file with comments | « components/cronet/android/test/quic_test_server.cc ('k') | components/cronet/android/test/test_upload_data_stream_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698