components/dom_distiller/content/browser/distillable_page_utils_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/browser/distillable_page_utils_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/test_upload_data_stream_handler.cc ('k') | components/dom_distiller/core/distilled_page_prefs_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/browser/distillable_page_utils_android.cc

diff --git a/components/dom_distiller/content/browser/distillable_page_utils_android.cc b/components/dom_distiller/content/browser/distillable_page_utils_android.cc

index bf1f80dbe17cca72b5bac8b267b9f84ee12c1d7e..56dfffaf18ec47497acac7f153272cbd42e6989d 100644

--- a/components/dom_distiller/content/browser/distillable_page_utils_android.cc

+++ b/components/dom_distiller/content/browser/distillable_page_utils_android.cc

@@ -25,10 +25,10 @@ void OnIsPageDistillableResult(

} // namespace

static void IsPageDistillable(JNIEnv* env,

- jclass jcaller,

- jobject webContents,

+ const JavaParamRef<jclass>& jcaller,

+ const JavaParamRef<jobject>& webContents,

jboolean is_mobile_optimized,

- jobject callback) {

+ const JavaParamRef<jobject>& callback) {

content::WebContents* web_contents(

content::WebContents::FromJavaWebContents(webContents));

scoped_ptr<ScopedJavaGlobalRef<jobject>> callback_holder(