Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/cronet/android/test/quic_test_server.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/quic_test_server.cc
diff --git a/components/cronet/android/test/quic_test_server.cc b/components/cronet/android/test/quic_test_server.cc
index b26a90de7f3f10e6218be0ae447723a05263ab0d..cb6d926a991952d81ec9685ca90778a2cb6a9a17 100644
--- a/components/cronet/android/test/quic_test_server.cc
+++ b/components/cronet/android/test/quic_test_server.cc
@@ -56,8 +56,8 @@ void ShutdownOnServerThread() {
// Quic server is currently hardcoded to run on port 6121 of the localhost on
// the device.
void StartQuicTestServer(JNIEnv* env,
- jclass /*jcaller*/,
- jstring jtest_files_root) {
+ const JavaParamRef<jclass>& /*jcaller*/,
+ const JavaParamRef<jstring>& jtest_files_root) {
DCHECK(!g_quic_server_thread);
g_quic_server_thread = new base::Thread("quic server thread");
base::Thread::Options thread_options;
@@ -70,18 +70,21 @@ void StartQuicTestServer(JNIEnv* env,
FROM_HERE, base::Bind(&ServeFilesFromDirectory, test_files_root));
}
-void ShutdownQuicTestServer(JNIEnv* env, jclass /*jcaller*/) {
+void ShutdownQuicTestServer(JNIEnv* env,
+ const JavaParamRef<jclass>& /*jcaller*/) {
DCHECK(!g_quic_server_thread->task_runner()->BelongsToCurrentThread());
g_quic_server_thread->task_runner()->PostTask(
FROM_HERE, base::Bind(&ShutdownOnServerThread));
delete g_quic_server_thread;
}
-ScopedJavaLocalRef<jstring> GetServerHost(JNIEnv* env, jclass /*jcaller*/) {
+ScopedJavaLocalRef<jstring> GetServerHost(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& /*jcaller*/) {
return base::android::ConvertUTF8ToJavaString(env, kServerHost);
}
-int GetServerPort(JNIEnv* env, jclass /*jcaller*/) {
+int GetServerPort(JNIEnv* env, const JavaParamRef<jclass>& /*jcaller*/) {
return kServerPort;
}
« no previous file with comments | « components/cronet/android/test/network_change_notifier_util.cc ('k') | components/cronet/android/test/sdch_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698