chrome/browser/ui/android/toolbar/toolbar_model_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/toolbar/toolbar_model_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc ('k') | chrome/browser/ui/android/website_settings_popup_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/toolbar/toolbar_model_android.cc

diff --git a/chrome/browser/ui/android/toolbar/toolbar_model_android.cc b/chrome/browser/ui/android/toolbar/toolbar_model_android.cc

index 2ce0ed4cd0f0c7d538885c55fec6fd92ab098e38..293eaf81719832cc26341d33bd78dcf43466ebd7 100644

--- a/chrome/browser/ui/android/toolbar/toolbar_model_android.cc

+++ b/chrome/browser/ui/android/toolbar/toolbar_model_android.cc

@@ -65,7 +65,9 @@ bool ToolbarModelAndroid::RegisterToolbarModelAndroid(JNIEnv* env) {

}

// static

-jlong Init(JNIEnv* env, jobject obj, jobject delegate) {

+jlong Init(JNIEnv* env,

+ const JavaParamRef<jobject>& obj,

+ const JavaParamRef<jobject>& delegate) {

ToolbarModelAndroid* toolbar_model = new ToolbarModelAndroid(env, delegate);

return reinterpret_cast<intptr_t>(toolbar_model);

}

@@ -79,8 +81,8 @@ jlong Init(JNIEnv* env, jobject obj, jobject delegate) {

// static

jboolean IsDeprecatedSHA1Present(JNIEnv* env,

- jclass jcaller,

- jobject jweb_contents) {

+ const JavaParamRef<jclass>& jcaller,

+ const JavaParamRef<jobject>& jweb_contents) {

content::WebContents* web_contents =

content::WebContents::FromJavaWebContents(jweb_contents);

DCHECK(web_contents);