Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
diff --git a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
index 2f9000979a0f3cf0a4b5d6a35be16aaf72b26772..1f2fa2d05ad67953f9bcf285abc0ccf1680d08ba 100644
--- a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
+++ b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
@@ -158,7 +158,7 @@ inline static base::TimeDelta GetTimeDelta(jlong ms) {
}
void LogFromCloseMetric(JNIEnv* env,
- jclass jcaller,
+ const JavaParamRef<jclass>& jcaller,
jlong ms,
jboolean perceived) {
if (perceived) {
@@ -171,7 +171,7 @@ void LogFromCloseMetric(JNIEnv* env,
}
void LogFromExitMetric(JNIEnv* env,
- jclass jcaller,
+ const JavaParamRef<jclass>& jcaller,
jlong ms,
jboolean perceived) {
if (perceived) {
@@ -184,7 +184,7 @@ void LogFromExitMetric(JNIEnv* env,
}
void LogFromNewMetric(JNIEnv* env,
- jclass jcaller,
+ const JavaParamRef<jclass>& jcaller,
jlong ms,
jboolean perceived) {
if (perceived) {
@@ -197,7 +197,7 @@ void LogFromNewMetric(JNIEnv* env,
}
void LogFromUserMetric(JNIEnv* env,
- jclass jcaller,
+ const JavaParamRef<jclass>& jcaller,
jlong ms,
jboolean perceived) {
if (perceived) {
@@ -217,7 +217,9 @@ bool TabModelJniBridge::Register(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-static jlong Init(JNIEnv* env, jobject obj, jboolean is_incognito) {
+static jlong Init(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jboolean is_incognito) {
TabModel* tab_model = new TabModelJniBridge(env, obj, is_incognito);
return reinterpret_cast<intptr_t>(tab_model);
}
« no previous file with comments | « chrome/browser/ui/android/tab_model/single_tab_model.cc ('k') | chrome/browser/ui/android/toolbar/toolbar_model_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698