chrome/browser/ui/android/website_settings_popup_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/website_settings_popup_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/toolbar/toolbar_model_android.cc ('k') | chromecast/android/cast_metrics_helper_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/website_settings_popup_android.cc

diff --git a/chrome/browser/ui/android/website_settings_popup_android.cc b/chrome/browser/ui/android/website_settings_popup_android.cc

index 4b4c9f17ef7da55c1b59d95a18193ae9b137d29c..3b1c91c330bfedb8d74f372fc65519fc8bb10de0 100644

--- a/chrome/browser/ui/android/website_settings_popup_android.cc

+++ b/chrome/browser/ui/android/website_settings_popup_android.cc

@@ -27,9 +27,9 @@ using base::android::ConvertUTF8ToJavaString;

// static

static jlong Init(JNIEnv* env,

- jclass clazz,

- jobject obj,

- jobject java_web_contents) {

+ const JavaParamRef<jclass>& clazz,

+ const JavaParamRef<jobject>& obj,

+ const JavaParamRef<jobject>& java_web_contents) {

content::WebContents* web_contents =

content::WebContents::FromJavaWebContents(java_web_contents);

« no previous file with comments | « chrome/browser/ui/android/toolbar/toolbar_model_android.cc ('k') | chromecast/android/cast_metrics_helper_android.cc » ('j') | no next file with comments »